fix(ci): label new PRs with pending-maintainer even without comments#709
Merged
fix(ci): label new PRs with pending-maintainer even without comments#709
Conversation
New PRs with no human comments were skipped by the pending-maintainer workflow because it required the last commenter to be the PR author. This meant freshly opened PRs would never get the label until the author left a comment — which is not normal PR workflow. Fix: treat no-human-comments as 'awaiting first review' and fall through to add pending-maintainer. Only skip when the last human comment is from someone other than the PR author (ball is with contributor).
shaun-agent posts screening reports as a member account (not GitHub Bot type), so it was counted as a human commenter. This could prevent pending-maintainer from being applied when shaun-agent was the last commenter. Exclude it by login name alongside the existing Bot type filter.
thepagent
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
New PRs with no human comments were never labeled
pending-maintainerbecause the workflow required the last commenter to be the PR author. Since PR authors don't normally leave a comment after opening a PR, these PRs would sit unlabeled indefinitely.Root Cause
This treats "no comments" as "not ready for maintainer", but the correct interpretation is "new PR awaiting first review".
Fix
pending-maintainerpending-maintainerpending-maintainerContext
Discovered while reviewing PR #696 — it had
pending-screeningbut never gotpending-maintainerbecause the author never commented.Discord Discussion
https://discord.com/channels/1490282656913559673/1500294765164498944